public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Badalian Vyacheslav <slavon@bigtelecom•ru>
To: Jarek Poplawski <jarkao2@gmail•com>
Cc: David Miller <davem@davemloft•net>,
	Stephen Hemminger <shemminger@vyatta•com>,
	"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH v2 net-next] Re: can't add tc multiq
Date: Tue, 10 Feb 2009 14:30:28 +0300	[thread overview]
Message-ID: <49916554.3040201@bigtelecom.ru> (raw)
In-Reply-To: <20090210074154.GA4190@ff.dom.local>

Thanks all! i will go to buy e1000e.
> On Mon, Feb 09, 2009 at 02:40:52PM -0800, Stephen Hemminger wrote:
> ...
>   
>> Rather than warning which will buried off on some console that user will never
>> see (and can cause DoS overload). A better errno should be chosen.
>>     
>
> I think admins are used to reading console messages, but we can try
> with a better errno too.
>
> Thanks,
> Jarek P.
> -------------------> take 2
>
> pkt_sched: sch_multiq: Change errno on non-multiqueue devices use.
>
> Current "RTNETLINK answers: Invalid argument" warning, while trying to
> add multiq qdisc to non-multiqueue device, isn't very helpful and some
> of these devs can be changed btw., so let's use a better errno.
>
> With feedback from Stephen Hemminger <shemminger@vyatta•com>
>
> Reported-by: Badalian Vyacheslav <slavon@bigtelecom•ru>
> Signed-off-by: Jarek Poplawski <jarkao2@gmail•com>
> ---
>
>  net/sched/sch_multiq.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/sched/sch_multiq.c b/net/sched/sch_multiq.c
> index 7e15186..9127312 100644
> --- a/net/sched/sch_multiq.c
> +++ b/net/sched/sch_multiq.c
> @@ -202,7 +202,7 @@ static int multiq_tune(struct Qdisc *sch, struct nlattr *opt)
>  	int i;
>  
>  	if (!netif_is_multiqueue(qdisc_dev(sch)))
> -		return -EINVAL;
> +		return -EOPNOTSUPP;
>  	if (nla_len(opt) < sizeof(*qopt))
>  		return -EINVAL;
>  
>
>   

next prev parent reply	other threads:[~2009-02-10 11:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-09  8:43 can't add tc multiq Badalian Vyacheslav
2009-02-09 16:15 ` Stephen Hemminger
2009-02-09 21:44   ` [PATCH net-next] " Jarek Poplawski
2009-02-09 22:40     ` Stephen Hemminger
2009-02-10  7:41       ` [PATCH v2 " Jarek Poplawski
2009-02-10  8:11         ` David Miller
2009-02-10 11:30         ` Badalian Vyacheslav [this message]
2009-02-10 11:57           ` Jarek Poplawski
2009-02-10 12:07             ` Badalian Vyacheslav
2009-02-10 12:18               ` Jarek Poplawski
2009-02-10 12:22                 ` Badalian Vyacheslav
2009-02-10 11:37   ` Badalian Vyacheslav
2009-02-10 16:53     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49916554.3040201@bigtelecom.ru \
    --to=slavon@bigtelecom$(echo .)ru \
    --cc=davem@davemloft$(echo .)net \
    --cc=jarkao2@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=shemminger@vyatta$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox