Subject: Re: [RFC] netlink broadcast return value

From: Patrick McHardy <[email-masked]>
Date: Thu, 12 Feb 2009 13:48:09 +0100

Pablo Neira Ayuso wrote:
> Oh, and also for this:
> 
>> 	if (p->skb2 == NULL) {
>> 		netlink_overrun(sk);
>> 		/* Clone failed. Notify ALL listeners. */
>> 		p->failure = 1;
>                 ^^^^^^^^^^^^^^^
> 
> if (nlk->flags & NETLINK_HIGHLY_RELIABLE)
> 	p->failure = 1;

I always wondered about the intention behind this. It wouldn't
hurt to just try the other allocation and see if they also fail.