Subject: Re: [PATCH] ipv6: Remove some pointless conditionals before kfree_skb()

From: Yang Hongyang <[email-masked]>
Date: Tue, 24 Feb 2009 17:54:25 +0800

Herbert Xu wrote:
> Yang Hongyang <[email-masked]> wrote:
>> I think kfree_skb() suppose that you have handled NULL pointer 
>> because it uses `unlikely` to check the pointer.
>> So I don't think these conditions are pointless...
>> 437 void kfree_skb(struct sk_buff *skb)
>> 438 {
>> 439         if (unlikely(!skb))
>> 440                 return;
> 
> These checks were specifically added so that callers didn't have
> to check for NULL.

Yes,but if the the callers checked for NULL,it's OK right?

> Cheers,

-- 
Regards
Yang Hongyang