From: Wei Yongjun <yjwei@cn•fujitsu.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols•net>
Cc: netdev@vger•kernel.org
Subject: [PATCH] llc: remove some pointless conditionals before kfree_skb()
Date: Wed, 25 Feb 2009 18:42:22 +0800 [thread overview]
Message-ID: <49A5208E.3050302@cn.fujitsu.com> (raw)
Remove some pointless conditionals before kfree_skb().
Signed-off-by: Wei Yongjun <yjwei@cn•fujitsu.com>
---
net/llc/llc_conn.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/net/llc/llc_conn.c b/net/llc/llc_conn.c
index 5c6d89c..3477624 100644
--- a/net/llc/llc_conn.c
+++ b/net/llc/llc_conn.c
@@ -332,8 +332,7 @@ int llc_conn_remove_acked_pdus(struct sock *sk, u8 nr, u16 *how_many_unacked)
for (i = 0; i < pdu_pos && i < q_len; i++) {
skb = skb_dequeue(&llc->pdu_unack_q);
- if (skb)
- kfree_skb(skb);
+ kfree_skb(skb);
nbr_acked++;
}
out:
--
1.5.3.8
next reply other threads:[~2009-02-25 10:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 10:42 Wei Yongjun [this message]
2009-02-27 7:09 ` [PATCH] llc: remove some pointless conditionals before kfree_skb() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A5208E.3050302@cn.fujitsu.com \
--to=yjwei@cn$(echo .)fujitsu.com \
--cc=acme@ghostprotocols$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox