Subject: Re: [PATCH] sungem: another error printed one too early

From: Roel Kluin <[email-masked]>
Date: Thu, 26 Feb 2009 13:55:43 +0100

Roel Kluin wrote:
> Another error was printed one too early.
> 
> Signed-off-by: Roel Kluin <[email-masked]>
> ---

I am not sure why my script didn't report this earlier.
-----------------------------------------------------
Another error was printed one too early.

Signed-off-by: Roel Kluin <[email-masked]>
---
diff --git a/drivers/net/sungem.c b/drivers/net/sungem.c
index 8d64b1d..0fcb750 100644
--- a/drivers/net/sungem.c
+++ b/drivers/net/sungem.c
@@ -1229,7 +1229,7 @@ static void gem_reset(struct gem *gp)
 			break;
 	} while (val & (GREG_SWRST_TXRST | GREG_SWRST_RXRST));
 
-	if (limit <= 0)
+	if (limit < 0)
 		printk(KERN_ERR "%s: SW reset is ghetto.\n", gp->dev->name);
 
 	if (gp->phy_type == phy_serialink || gp->phy_type == phy_serdes)