From: Divy Le Ray <divy@chelsio•com>
To: Herbert Xu <herbert@gondor•apana.org.au>
Cc: netdev@vger•kernel.org
Subject: Re: cxgb3: Replace LRO with GRO
Date: Fri, 13 Mar 2009 00:28:52 -0700 [thread overview]
Message-ID: <49BA0B34.7050502@chelsio.com> (raw)
In-Reply-To: <20090216033644.GA14431@gondor.apana.org.au>
> When you can get a chance can you see if this patch makes any
> difference at all?
Hi Herbert,
Sorry for the delay.
I had to switch to different development platforms.
I've not seen much perf change with this patch, it looks good though.
Cheers,
Divy
>
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index d7efaf9..6a542fa 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -2586,8 +2586,10 @@ int skb_gro_receive(struct sk_buff **head, struct sk_buff *skb)
> {
> struct sk_buff *p = *head;
> struct sk_buff *nskb;
> + skb_frag_t *frag;
> unsigned int headroom;
> unsigned int len = skb_gro_len(skb);
> + int i;
>
> if (p->len + len >= 65536)
> return -E2BIG;
> @@ -2604,9 +2606,9 @@ int skb_gro_receive(struct sk_buff **head, struct sk_buff *skb)
> skb_shinfo(skb)->frags[0].size -=
> skb_gro_offset(skb) - skb_headlen(skb);
>
> - memcpy(skb_shinfo(p)->frags + skb_shinfo(p)->nr_frags,
> - skb_shinfo(skb)->frags,
> - skb_shinfo(skb)->nr_frags * sizeof(skb_frag_t));
> + frag = skb_shinfo(p)->frags + skb_shinfo(p)->nr_frags;
> + for (i = 0; i < skb_shinfo(skb)->nr_frags; i++)
> + *frag++ = skb_shinfo(skb)->frags[i];
>
> skb_shinfo(p)->nr_frags += skb_shinfo(skb)->nr_frags;
> skb_shinfo(skb)->nr_frags = 0;
>
> Thanks,
next prev parent reply other threads:[~2009-03-13 7:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 10:14 cxgb3: Replace LRO with GRO Divy Le Ray
2009-01-21 8:29 ` Herbert Xu
2009-01-22 9:42 ` Divy Le Ray
2009-02-16 3:36 ` Herbert Xu
2009-02-16 3:47 ` Divy Le Ray
2009-03-13 7:28 ` Divy Le Ray [this message]
2009-04-13 15:24 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2009-01-15 21:14 Divy Le Ray
2009-01-15 23:58 ` Herbert Xu
2009-01-16 8:06 ` Divy Le Ray
2009-01-16 8:56 ` Herbert Xu
2009-01-16 11:12 ` Divy Le Ray
2009-01-16 23:58 ` Herbert Xu
2009-01-17 5:08 ` Herbert Xu
2009-01-17 11:11 ` Divy Le Ray
2009-01-17 13:08 ` Herbert Xu
2009-01-18 20:33 ` Divy Le Ray
2009-01-18 22:50 ` Herbert Xu
2009-01-20 1:03 ` David Miller
2009-01-20 2:03 ` David Miller
2009-01-20 5:24 ` Herbert Xu
2009-01-20 10:04 ` Divy Le Ray
2009-01-13 9:26 [1/2] e1000e: Invoke VLAN GRO handler Herbert Xu
2009-01-15 6:59 ` cxgb3: Replace LRO with GRO Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49BA0B34.7050502@chelsio.com \
--to=divy@chelsio$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox