Subject: Re: [RFC] net: release dst entry in dev_queue_xmit()

From: Jarek Poplawski <[email-masked]>
Date: Wed, 25 Mar 2009 19:22:16 +0100

David Miller wrote, On 03/25/2009 08:17 AM:

> From: Eric Dumazet <[email-masked]>
> Date: Wed, 25 Mar 2009 08:13:30 +0100
> 
>> If done in dev_hard_start_xmit(), skb could be requeued (because of
>> NETDEV_TX_BUSY).  Then if requeued, maybe at this time, dst being
>> NULL is not a problem ?
> 
> Usually it should be OK because the packet schedulers have
> a sort-of one-behind state that allows them to reinsert
> the SKB into their queue datastructures without reclassifying.

Actually, since David has dumped requeuing there is no reinserting;
this last one "requeued" skb is buffered at the top in q->gso_skb
and waiting for better times.

Jarek P.