Subject: Re: [PATCH] FEC driver: patches for -next

From: Greg Ungerer <[email-masked]>
Date: Wed, 15 Apr 2009 22:12:05 +1000

Hi Sascha,

Sascha Hauer wrote:
> These patches aim to modernize the FEC ethernet driver.
> Greg, can you please confirm that the ifdef in patch 01/12 is indeed unused?

It is used for the CONFIG_M5272 case. The offsets to some registers
are slightly different for the version of the FEC hardware in that
SoC CPU.

Regards
Greg

> The following changes since commit 0882e8dd3aad33eca41696d463bb896e6c8817eb:
>   Linus Torvalds (1):
>         Linux 2.6.30-rc2
> 
> are available in the git repository at:
> 
>   git://git.pengutronix.de/git/sha/linux-2.6.git fec
> 
> Sascha Hauer (12):
>       fec: remove unused ifdef
>       fec: switch to writel/readl
>       fec: do not typedef struct types
>       fec: remove unnecessary cast
>       fec: Codingstyle cleanups
>       fec: refactor set_multicast_list() to make it more readable
>       fec: refactor init function
>       fec: align receive packets
>       fec: remove debugging printks
>       fec: switch to net_device_ops
>       FEC Buffer rework
>       fec: call fec_restart() in fec_open()
> 
>  drivers/net/fec.c |  897 ++++++++++++++++++++++-------------------------------
>  drivers/net/fec.h |  112 ++-----
>  2 files changed, 402 insertions(+), 607 deletions(-)
> 

-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     [email-masked]
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com