Subject: [IPV6]: ROUTE:read ifname in rt6_info_route()

From: Yuta sugiura <[email-masked]>
Date: Thu, 16 Apr 2009 20:05:05 +0900

Hi,
I have a suggestion about /proc/net/IPv6_route format.
In rt6_info_route(),  interface name is treated as a maximum 8 characters.
But the type of (struct rt6_inf *)->u.dst.dev->name is char[IFNAMESIZ= 16]
so, I think that it should change "%8s" to "%16s".

Thanks,

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 1394ddb..9ad58e7 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2434,7 +2434,7 @@ static int ip6_route_dev_notify(struct notifier_block *this,
 
 #ifdef CONFIG_PROC_FS
 
-#define RT6_INFO_LEN (32 + 4 + 32 + 4 + 32 + 40 + 5 + 1)
+#define RT6_INFO_LEN (32 + 4 + 32 + 4 + 32 + 48 + 5 + 1)
 
 struct rt6_proc_arg
 {
@@ -2462,7 +2462,7 @@ static int rt6_info_route(struct rt6_info *rt, void *p_arg)
 	} else {
 		seq_puts(m, "00000000000000000000000000000000");
 	}
-	seq_printf(m, " %08x %08x %08x %08x %8s\n",
+	seq_printf(m, " %08x %08x %08x %08x %16s\n",
 		   rt->rt6i_metric, atomic_read(&rt->u.dst.__refcnt),
 		   rt->u.dst.__use, rt->rt6i_flags,
 		   rt->rt6i_dev ? rt->rt6i_dev->name : "");