Subject: RE: [PATCH net 2/9] r8152: reset flow control patch when linking on for RTL8153B

From: Hayes Wang <[email-masked]>
Date: Tue, 21 Jan 2020 13:19:19 +0000

Joe Perches [mailto:[email-masked]]
> Sent: Tuesday, January 21, 2020 9:01 PM
> To: David Miller; Hayes Wang
[...]
> > >  static int rtl8153_enable(struct r8152 *tp)
> > >  {
> > > +     u32 ocp_data;
> > >       if (test_bit(RTL8152_UNPLUG, &tp->flags))
> > >               return -ENODEV;
> > >
> >
> > Please put an empty line after the local variable declarations.
> 
> Local scoping is generally better.
> 
> Perhaps declare ocp_data inside the if branch
> where it's used.

OK. I would move it.

Best Regards,
Hayes