Subject: Re: [PATCH] remove DMA_nBIT_MASK macro

From: Yang Hongyang <[email-masked]>
Date: Thu, 07 May 2009 16:29:21 +0800

Andrew Morton wrote:
> On Thu, 7 May 2009 14:14:16 +0900 FUJITA Tomonori <[email-masked]> wrote:
> 
>> We replaced all DMA_nBIT_MASK macros with DMA_BIT_MASK(n) but why do
>> we still keep DMA_nBIT_MASK macros in include/linux/dma-mapping.h?
>>
>> As long as these macros exist, people use them. The current git has
>> two users and linux-next have other users.
>>
>> Is it better to remove DMA_nBIT_MASK macros completely now?
> 
> Yes, the plan is to remove them.
> 
> Doing so will break lots and lots of out-of-tree drivers, causing
> people some grief.  Is there any way in which we can cause their use to
> cause __deprecated warnings for a couple of months, to give people a
> chance to migrate?
> 
> 

Shall we use something like below to warn people?
#define DMA_64BIT_MASK	DMA_BIT_MASK(64);(__deprecated warnings:use DMA_BIT_MASK(64) instead) ?

-- 
Regards
Yang Hongyang