Subject: Re: [PATCH]ipv6:use ipv6_addr_type instead of __ipv6_addr_type

From: Yang Hongyang <[email-masked]>
Date: Fri, 08 May 2009 09:18:11 +0800

David Miller wrote:
> From: Yang Hongyang <[email-masked]>
> Date: Thu, 07 May 2009 15:47:38 +0800
> 
>> Although the function of these two functions are the same,we should use the
>> encapsulation function of __ipv6_addr_type
>>
>> Signed-off-by: Yang Hongyang<[email-masked]>
> 
> Are you sure?  ipv6_addr_type() masks out the upper 16-bits
> of __ipv6_addr_type()'s return value, which is the scope.
> 
> I'm not convinced that is what we want to do here.

My advice here is that the function which has __ maybe shouldn't be directly used.

Since the return of  __ipv6_addr_type is needed by 
__ipv6_addr_src_scope,there should comes another patch to covert use of
__ipv6_addr_src_scope to ipv6_addr_src_scope.To make this serie of the
patch shouldn't be a problem because there are not so much use of these, 
two or three places.

That's my advice.:)

-- 
Regards
Yang Hongyang