From: Oliver Hartkopp <oliver.hartkopp@volkswagen•de>
To: Wolfgang Grandegger <wg@grandegger•com>,
Subrata Modak <subrata@linux•vnet.ibm.com>
Cc: ltp-list <ltp-list@lists•sf.net>,
socketcan-users@lists•berlios.de, netdev@vger•kernel.org
Subject: Re: [PATCH v2 0/7] can: CAN network device driver interface and drivers
Date: Tue, 12 May 2009 12:46:11 +0200 [thread overview]
Message-ID: <4A095373.9010205@volkswagen.de> (raw)
In-Reply-To: <4A094833.7030006@grandegger.com>
Wolfgang Grandegger wrote:
> Subrata Modak wrote:
>> Hi Oliver/Wolfgang,
>>
>>> Hello,
>>>
>>> here comes v2 of the patch series posted some time ago. See
>>>
>>> http://marc.info/?l=linux-netdev&m=123507025810612&w=4.
>>>
>>> Changes since v1:
> [...]
>> Would you also like to send a patch to update the testcases for CAN in LTP
>> (http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/testcases/network/can/filter-tests/) ?
>> These tests were originally picked up from:
>> http://svn.berlios.de/wsvn/socketcan/trunk/test/?rev=877&sc=1
>
> The existing tests uses the vcan (virtual CAN) driver, which is not
> affected by these patches. Are you thinking about tests using *real* CAN
> devices?
>
Hi Subrata,
indeed extending the test-cases to the real CAN drivers would urge you
to add a least
two hardware CAN-interfaces to your test system and wire them correctly
with the
appropriate termination.
It's like having *all* ethernet cards available in your linux box to
test them ;-)
Some of these CAN controllers are only available as an on-chip device
(e.g. for some PowerPC CPUs).
If there is some room for LTP improvements, i would tend to create some
more test-cases
for the networklayer stuff in linux/net/can using the existent virtual
CAN driver.
Best regards,
Oliver
next prev parent reply other threads:[~2009-05-12 10:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 9:46 [PATCH v2 0/7] can: CAN network device driver interface and drivers Subrata Modak
2009-05-12 9:58 ` Wolfgang Grandegger
2009-05-12 10:46 ` Oliver Hartkopp [this message]
2009-05-12 10:59 ` Subrata Modak
2009-06-18 17:31 ` [LTP] [PATCH v2 0/7] can: CAN network device driver interfaceand drivers Subrata Modak
2011-07-10 12:18 ` Update for CAN LTP tests Oliver Hartkopp
2011-07-11 16:15 ` [LTP] " Cyril Hrubis
2011-07-11 17:32 ` CAN: major update for the Controller Area Network " Oliver Hartkopp
-- strict thread matches above, loose matches on Subject: below --
2009-05-12 9:27 [PATCH v2 0/7] can: CAN network device driver interface and drivers Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A095373.9010205@volkswagen.de \
--to=oliver.hartkopp@volkswagen$(echo .)de \
--cc=ltp-list@lists$(echo .)sf.net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=socketcan-users@lists$(echo .)berlios.de \
--cc=subrata@linux$(echo .)vnet.ibm.com \
--cc=wg@grandegger$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox