From: Jeff Garzik <jeff@garzik•org>
To: Matt Mackall <mpm@selenic•com>
Cc: Chris Peterson <cpeterso@cpeterso•com>,
linux-kernel@vger•kernel.org, NetDev <netdev@vger•kernel.org>
Subject: Re: [PATCH] [resend] drivers/net: remove network drivers' last few uses of IRQF_SAMPLE_RANDOM
Date: Wed, 13 May 2009 15:39:11 -0400 [thread overview]
Message-ID: <4A0B21DF.9050702@garzik.org> (raw)
In-Reply-To: <20090513142535.GB31071@waste.org>
Matt Mackall wrote:
> On Wed, May 13, 2009 at 12:17:29AM -0700, Chris Peterson wrote:
>>> The future model will continue to sample network
>>> devices on theory that they -might- be less than 100% observable and
>>> that can only increase our total (unmeasurable) amount of entropy.
>> That sounds reasonable to me. So should all net drivers now specify
>> IRQF_SAMPLE_RANDOM?
>>
>> Or even simpler: could request_irq() assume IRQF_SAMPLE_RANDOM for any
>> interrupt that is not (say) IRQF_IRQPOLL or IRQF_PERCPU?
>
> Maybe. We don't want IRQ latency to suffer. So before we turn on
> sampling of -all- sources, we need to make sampling lighter weight and
> we need a way to say 'we have enough' so that we're not consuming CPU
> when our pools are 'full'. We could turn it on now and rely on the
> current trickle logic, but it's nice to have the water main off when
> doing significant plumbing.
So, until such time, let's be consistent in net driver land and not
IRQF_SAMPLE_RANDOM.
Jeff
next parent reply other threads:[~2009-05-13 19:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.00.0905130118140.15823@ubuntu-desktop>
[not found] ` <20090513060850.GZ31071@waste.org>
[not found] ` <a24804730905130017t545b7645x71ab7a1c8ab4af78@mail.gmail.com>
[not found] ` <20090513142535.GB31071@waste.org>
2009-05-13 19:39 ` Jeff Garzik [this message]
2009-05-13 19:55 ` [PATCH] [resend] drivers/net: remove network drivers' last few uses of IRQF_SAMPLE_RANDOM Matt Mackall
2008-06-14 5:48 Chris Peterson
2008-06-14 9:43 ` Jeff Garzik
[not found] <ayJOq-3EJ-15@gated-at.bofh.it>
2008-05-29 12:41 ` Martin Wilck
-- strict thread matches above, loose matches on Subject: below --
2008-05-29 6:23 Chris Peterson
2008-05-29 10:49 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0B21DF.9050702@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=cpeterso@cpeterso$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mpm@selenic$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox