public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Claude Robitaille <clauder@accedian•com>
To: netdev@vger•kernel.org
Subject: sk_buff handling in packet handler
Date: Sat, 16 May 2009 12:31:28 -0400	[thread overview]
Message-ID: <4A0EEA60.6090702@accedian.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]

Hi all,

My question is a development question so I hope this is the correct list 
to post it. If not just tell me and I will find another list...

I am developing a packet handler that I register via dev_add_pack. All 
is fine except that after a while the kernel crashes. I suspect my 
handler not doing something correct...

The handler is registered with the ETH_P_ALL list, listening on a 
specific interface.

After many attempt at reducing the scope of what my handler is doing I 
now simply do a return in my handler. When I send lots of frames to 
interface that I am listening to after a while I start getting kernel 
messages about low memory and eventually even get exception dumps.

I suspect that the handler needs to do something with the sk_buff but I 
am not sure what. I printed the content of the sk_buff and found that 
the skb_buff is not cloned (looking on the web I had found that the 
sk_buff should have been cloned) and that he number of users is 1.

Should I simply do a dev_kfree_skb? What are the rules governing the use 
of the sk_buff in a packet handler? Should I clone the sk_buff?

Also, a related question, the packet handler is expected to return an 
int. What should be returned?

Thanks

Claude
 

[-- Attachment #2: clauder.vcf --]
[-- Type: text/x-vcard, Size: 176 bytes --]

begin:vcard
fn:Claude Robitaille
n:Robitaille;Claude
email;internet:clauder@accedian•com
tel;work:514-764-0119
tel;cell:514-796-7225
x-mozilla-html:TRUE
version:2.1
end:vcard

next             reply	other threads:[~2009-05-16 16:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-16 16:31 Claude Robitaille [this message]
2009-05-16 20:19 ` sk_buff handling in packet handler Evgeniy Polyakov
  -- strict thread matches above, loose matches on Subject: below --
2009-05-17  0:55 Mark Smith
2009-05-17 17:23 ` Claude Robitaille
2009-05-18  5:38   ` Stephen Hemminger
2009-05-19 22:41 ` Claude Robitaille

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0EEA60.6090702@accedian.com \
    --to=clauder@accedian$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox