From: Chaitanya Lala <clala@riverbed•com>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: "jesse.brandeburg@intel•com" <jesse.brandeburg@intel•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [net-next-2.6 PATCH 1/1] e1000e: Expose MDI-X status via ethtool change
Date: Fri, 22 May 2009 08:24:25 -0700 [thread overview]
Message-ID: <4A16C3A9.3070402@riverbed.com> (raw)
In-Reply-To: <1243004704.3192.21.camel@achroite>
Ben Hutchings wrote:
> On Fri, 2009-05-22 at 07:55 -0700, Chaitanya Lala wrote:
>
>> Ethtool is a standard way of getting information about ethernet
>> interfaces. We enhance ethtool kernel interface & e1000e to make
>> the MDI-X status readable via ethtool in userspace.
>>
> [...]
>
>> diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
>> index 380b042..0533d70 100644
>> --- a/include/linux/ethtool.h
>> +++ b/include/linux/ethtool.h
>> @@ -26,6 +26,7 @@ struct ethtool_cmd {
>> __u8 phy_address;
>> __u8 transceiver; /* Which transceiver to use */
>> __u8 autoneg; /* Enable or disable autonegotiation */
>> + __u8 is_mdix; /* MDI-X status tri-state value */
>> __u8 mdio_support;
>>
> [...]
>
> There's no gap here, so this would move all the following fields and
> break all older ethtool clients.
>
> Ben.
>
>
Then should I move it to the bottom ?
Chaitanya
next prev parent reply other threads:[~2009-05-22 15:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <F169D4F5E1F1974DBFAFABF47F60C10A33527C9D@orsmsx507.amr.corp.intel.com>
2009-05-22 14:54 ` [PATCH 1/1] ethtool: Expose MDI-X status Chaitanya Lala
2009-05-22 15:02 ` Stephen Hemminger
2009-05-22 15:03 ` Ben Hutchings
2009-05-22 14:55 ` [net-next-2.6 PATCH 1/1] e1000e: Expose MDI-X status via ethtool change Chaitanya Lala
2009-05-22 15:05 ` Ben Hutchings
2009-05-22 15:24 ` Chaitanya Lala [this message]
2009-05-22 17:18 ` [PATCH 1/1] ethtool: Expose MDI-X status Chaitanya Lala
2009-05-23 1:04 ` Ben Hutchings
2009-05-26 15:34 ` Chaitanya Lala
2009-05-26 16:02 ` Ben Hutchings
2009-05-27 23:13 ` Chaitanya Lala
2009-05-27 23:15 ` [PATCH net-next-2.6 1/1] e1000e: Expose MDI-X status via ethtool change Chaitanya Lala
2009-06-02 23:02 ` Jeff Kirsher
2009-06-03 17:34 ` Ben Hutchings
2009-06-03 17:45 ` Chaitanya Lala
2009-06-03 21:04 ` Jeff Kirsher
2009-06-03 21:19 ` Chaitanya Lala
2009-06-03 21:31 ` Jeff Kirsher
2009-06-03 21:41 ` Chaitanya Lala
2009-06-10 19:11 ` Re-submit [PATCH 1/1] ethtool: Expose MDI-X status Chaitanya Lala
2009-06-10 19:22 ` Ben Hutchings
2009-05-22 17:20 ` [net-next-2.6 PATCH 1/1] e1000e: Expose MDI-X status via ethtool change Chaitanya Lala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A16C3A9.3070402@riverbed.com \
--to=clala@riverbed$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox