Subject: Re: [PATCH 2/3] sis190: fix gigabit negotiation

From: rgh <[email-masked]>
Date: Wed, 03 Jun 2009 08:15:16 +0200

Francois Romieu wrote:
> Riccardo Ghetta <[email-masked]> :
>> Fixes an initialization error; the chip negotiates gigabit, but
>> the driver mistakenly handled it as 100Mb.
> 
> Did you draw some inspiration from SiS own driver ? If so it would
> deserve to be quoted.
> 
Yes, I looked at both sis and forcedeth drivers. I'll quote both.

> val has been read from the LPA register.
> 
> s/ADVERTISE_NPAGE/LPA_NPAGE/ ?
Uhu, yes, sorry.