Subject: Re: [PATCH] forcedeth: Addition of new device id (resend without pci_ids.h)

From: Ayaz Abdulla <[email-masked]>
Date: Wed, 03 Jun 2009 12:24:37 -0400

David Miller wrote:
> From: Ayaz Abdulla <[email-masked]>
> Date: Wed, 03 Jun 2009 12:06:04 -0400
> 
> 
>>Add support for new ethernet device in the MCP89 chipset.
>>
>>Signed-off-by: Ayaz Abdulla <[email-masked]>
> 
> 
> Just use the constant directly, please :-)

But there is place in the patch that refers to device id so it makes 
more sense to have a macro. i.e

+       if (np->device_id != PCI_DEVICE_ID_NVIDIA_NVENET_40)

other places in the code also refer to device ids for certain 
workarounds. i.e.

		if ((id->device == PCI_DEVICE_ID_NVIDIA_NVENET_12 ||
		     id->device == PCI_DEVICE_ID_NVIDIA_NVENET_13) &&

> 
> The new macro is completely superfluous.
> 
> Trust me, other drivers just use the PCI ID constant directly in their
> tables too, and no animals were harmed by the experiment :-)