Subject: Re: rfkill regression in net-next-2.6

From: Oliver Hartkopp <[email-masked]>
Date: Mon, 15 Jun 2009 15:20:59 +0200

Johannes Berg wrote:
> On Mon, 2009-06-15 at 08:04 -0400, John W. Linville wrote:
>> On Sun, Jun 14, 2009 at 10:54:17AM +0200, Oliver Hartkopp wrote:
>>
>>> Any idea what changed in net-next-2.6 that could produce this behaviour?
>> The rfkill subsystem rewrite would seem suspect... :-)
> 
> Maybe this fixes it?

Yes, that made it!

I booted with the RFKILL switch ON and OFF and the system and the LEDs are
working as one would expect it.

Thanks Johannes.

Tested-by: Oliver Hartkopp <[email-masked]>

> 
> johannes
> 
> --- wireless-testing.orig/drivers/platform/x86/dell-laptop.c	2009-06-15 14:23:25.000000000 +0200
> +++ wireless-testing/drivers/platform/x86/dell-laptop.c	2009-06-15 14:23:35.000000000 +0200
> @@ -177,7 +177,7 @@ dell_send_request(struct calling_interfa
>  static int dell_rfkill_set(void *data, bool blocked)
>  {
>  	struct calling_interface_buffer buffer;
> -	int disable = blocked ? 0 : 1;
> +	int disable = blocked ? 1 : 0;
>  	unsigned long radio = (unsigned long)data;
>  
>  	memset(&buffer, 0, sizeof(struct calling_interface_buffer));
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [email-masked]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html