Subject: Re: [PATCH] TCP: Add comments to (near) all functions in tcp_output.c v2

From: Shan Wei <[email-masked]>
Date: Mon, 20 Jul 2009 20:06:53 +0800

Andi Kleen said:
>  
> +/* Compute TCP options for ESTABLISHED sockets. This is not the
> + * final wire format yet.
> + */

typo, “network wire”?

> +/* Test if sending is allowed right now.
> + */
>  int tcp_may_send_now(struct sock *sk)

Is it better to provide the condition be allowed?

+ /* Check the nagle, the congestion window and 
+  * the send window, decide if sending is allowed right now.
+  */