Subject: Re: [PATCH] TCP: Add comments to (near) all functions in tcp_output.c v2

From: Shan Wei <[email-masked]>
Date: Mon, 20 Jul 2009 20:46:58 +0800

Andi Kleen said:
> On Mon, Jul 20, 2009 at 08:06:53PM +0800, Shan Wei wrote:
>> Andi Kleen said:
>>>  
>>> +/* Compute TCP options for ESTABLISHED sockets. This is not the
>>> + * final wire format yet.
>>> + */
>> typo, “network wire”?
> 
> I don't see a typo.

Just see the comment about tcp_syn_options().
"wire" vs "network wire".

> 
>>
>>> +/* Test if sending is allowed right now.
>>> + */
>>>  int tcp_may_send_now(struct sock *sk)
>> Is it better to provide the condition be allowed?
> 
> Such a introductionary comment is not intended to be a full
> representation of the code, just a overview.
> 

OK