From: Patrick McHardy <kaber@trash•net>
To: Jay Vosburgh <fubar@us•ibm.com>
Cc: Or Gerlitz <ogerlitz@voltaire•com>,
David Miller <davem@davemloft•net>,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next-2.6] bonding: propogate vlan_features to bonding master
Date: Thu, 23 Jul 2009 13:03:59 +0200 [thread overview]
Message-ID: <4A68439F.8060305@trash.net> (raw)
In-Reply-To: <3463.1248298460@death.nxdomain.ibm.com>
Jay Vosburgh wrote:
> Propogate the vlan_features of the slave devices to the bonding
> master device, using the same logic as for regular features.
>
> Tested by Or Gerlitz <ogerlitz@voltaire•com>, who also removed
> the debug logic from the original test patch.
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 3bf0cc6..5a8b882 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -1354,6 +1359,7 @@ static int bond_compute_features(struct bonding *bond)
> done:
> features |= (bond_dev->features & BOND_VLAN_FEATURES);
> bond_dev->features = netdev_fix_features(features, NULL);
> + bond_dev->vlan_features = netdev_fix_features(vlan_features, NULL);
You need to call netdev_features_change() to make sure the VLAN
code notices the change.
prev parent reply other threads:[~2009-07-23 11:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 13:00 zero features for a vlan over bond Or Gerlitz
2009-04-07 14:16 ` Jay Vosburgh
2009-04-07 22:16 ` Or Gerlitz
2009-04-16 14:11 ` zero features for a vlan over bond / vlan features Or Gerlitz
2009-04-23 23:47 ` Jay Vosburgh
2009-06-08 9:34 ` Or Gerlitz
2009-07-20 8:08 ` Or Gerlitz
2009-07-22 21:34 ` [PATCH net-next-2.6] bonding: propogate vlan_features to bonding master Jay Vosburgh
2009-07-23 6:03 ` Eric Dumazet
2009-07-23 7:24 ` Or Gerlitz
2009-07-23 8:29 ` [PATCH net-next-2.6] bnx2: Update vlan_features Eric Dumazet
2009-07-23 12:01 ` Eric Dumazet
2009-07-23 17:59 ` David Miller
2009-07-24 0:12 ` Michael Chan
2009-07-24 7:21 ` [PATCH net-next-2.6] bnx2x: Dont update vlan_features in bnx2x_set_tso() Eric Dumazet
2009-07-26 10:53 ` Eilon Greenstein
2009-07-27 2:49 ` David Miller
2009-07-27 2:50 ` [PATCH net-next-2.6] bnx2: Update vlan_features David Miller
2009-07-23 11:03 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A68439F.8060305@trash.net \
--to=kaber@trash$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=fubar@us$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@voltaire$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox