Subject: Re: [PATCH V2] CAN: Add Flexcan CAN controller driver

From: Oliver Hartkopp <[email-masked]>
Date: Tue, 28 Jul 2009 16:12:10 +0200

Oliver Hartkopp wrote:
> Sascha Hauer wrote:

>>>> +
>>>> +	if (frame->can_id & CAN_RTR_FLAG)
>>>> +		dlc |= MB_CNT_RTR;
>>>> +
>>>> +	writel(dlc, &regs->cantxfg[TX_BUF_ID].can_dlc);
>>>> +	writel(can_id, &regs->cantxfg[TX_BUF_ID].can_id);

Are you sure, that this is correct?

Indeed i wonder, if it would make sense to skip the entire struct flexcan_mb
approach and fiddle byte-by-byte inside the registers ...

Regards,
Oliver