Subject: Re: [PATCH] Fix Micrel KSZ8842 Kconfig description

From: Richard Röjfors<[email-masked]>
Date: Fri, 21 Aug 2009 15:06:27 +0200

Andreas Mohr wrote:
> Hi,
> 
> On Fri, Aug 21, 2009 at 12:36:49PM +0200, Richard Röjfors wrote:
>> Andreas Mohr wrote:
>>> Hi,
>>>
>>> when doing a "make oldconfig" recently, non-descriptive item "Micrel KSZ8842"
>>> came up, and when I hit "?" to get more info, all I got was a tight-lipped
>>> "This platform driver is for Micrel KSZ8842 chip.".
>> I see your pain
> 
> Thanks, and very fast reply too :)
> 
>> Remove "PCI-based"
>>
>> This is a platform device, it is not PCI based.
>> The KS8842 can sit behind PCI, ISA or VLB, this driver basically  
>> supports the ISA mappings.
>>
>> --Richard
> 
> OK, I had added that because manufacturer specifications seemed to suggest
> PCI use only. "platform device" should have been a warning sign I guess...
> 
> 
> Signed-off-by: Andreas Mohr <[email-masked]>

Looks good to me

Acked-by: Richard Röjfors <[email-masked]>

> 
> --- linux-2.6.31-rc6/drivers/net/Kconfig.orig	2009-08-21 12:00:31.000000000 +0200
> +++ linux-2.6.31-rc6/drivers/net/Kconfig	2009-08-21 12:41:48.000000000 +0200
> @@ -1727,7 +1727,8 @@ config KS8842
>  	tristate "Micrel KSZ8842"
>  	depends on HAS_IOMEM
>  	help
> -	  This platform driver is for Micrel KSZ8842 chip.
> +	  This platform driver is for Micrel KSZ8842 / KS8842
> +	  2-port ethernet switch chip (managed, VLAN, QoS).
>  
>  config KS8851
>         tristate "Micrel KS8851 SPI"
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [email-masked]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html