Subject: Re: [PATCH] netfilter: bridge: refcount fix

From: Patrick McHardy <[email-masked]>
Date: Mon, 24 Aug 2009 19:22:57 +0200

Eric Dumazet wrote:
> Hi David
> 
> I found following by code review only, I am not sure it is critical enough for net-2.6
> 
> This is a stable candidate, bug is more than 2 years old.
> 
> Thanks
> 
> commit f216f082b2b37c4943f1e7c393e2786648d48f6f
> ([NETFILTER]: bridge netfilter: deal with martians correctly)
> added a refcount leak on in_dev.
> 
> Signed-off-by: Eric Dumazet <[email-masked]>
> ---
> diff --git a/net/bridge/br_netfilter.c b/net/bridge/br_netfilter.c
> index 4fde742..c62eca3 100644
> --- a/net/bridge/br_netfilter.c
> +++ b/net/bridge/br_netfilter.c
> @@ -386,6 +386,7 @@ static int br_nf_pre_routing_finish(struct sk_buff *skb)
>  				dst_release((struct dst_entry *)rt);
>  			}
>  free_skb:
> +			in_dev_put(in_dev);
>  			kfree_skb(skb);
>  			return 0;

I guess we could simply use __in_dev_get_rcu() here since all
netfilter hooks are running under rcu_read_lock() anyways.