Subject: [PATCH] sky2: Don't try to turn led off in sky2_down()

From: Mike McCormack <[email-masked]>
Date: Sat, 29 Aug 2009 22:10:33 +0900

There are a few problems with the following line of code in sky2_down()

     sky2_write16(hw, B0_Y2LED, LED_STAT_OFF);

 * It doesn't specify which port's LED to turn off.
 * We don't turn send LED_STAT_ON on in sky2_up()
 * B0_LED is 0x0006 in the vendor driver, but 0x0005 in sky2.
   B0_LED is right next to B0_POWER_CTRL, so this is possibly
   accounts for the device being accidently powered down as
   reported by Rene Mayrhofer.

Signed-off-by: Mike McCormack <[email-masked]>
---
 drivers/net/sky2.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index dd630cf..aec8ad3 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -1866,9 +1866,6 @@ static int sky2_down(struct net_device *dev)
 	sky2_phy_power_down(hw, port);
 	spin_unlock_bh(&sky2->phy_lock);
 
-	/* turn off LED's */
-	sky2_write16(hw, B0_Y2LED, LED_STAT_OFF);
-
 	sky2_tx_reset(hw, port);
 
 	/* Free any pending frames stuck in HW queue */
-- 
1.5.6.5