Subject: Re: [PATCH net-next-2.6] vlan: adds drops accounting

From: Patrick McHardy <[email-masked]>
Date: Fri, 04 Sep 2009 13:59:24 +0200

David Miller wrote:
> From: Eric Dumazet <[email-masked]>
> Date: Thu, 03 Sep 2009 12:39:16 +0200
> 
>> Its hard to tell if vlans are dropping frames, since
>> every frame given to vlan_???_start_xmit() functions
>> is accounted as fully transmitted by lower device.
>>
>> We can test dev_queue_xmit() return values to
>> properly account for dropped frames.
>>
>> Signed-off-by: Eric Dumazet <[email-masked]>
> 
> Applied.
> 
> But, how inappropriate would it be to keep doing the accounting
> but pass the status back to the caller?  Or will that screw up
> the qdisc running engine?

Its currently not possible to return the dev_queue_xmit() status
from ndo_start_xmit(). My patch to extend the possible return
values will allow that. I hope I'm able to take care of it today.