Subject: Re: net_sched 00/07: classful multiqueue dummy scheduler

From: Patrick McHardy <[email-masked]>
Date: Sat, 05 Sep 2009 19:02:00 +0200

David Miller wrote:
> From: Patrick McHardy <[email-masked]>
> Date: Fri,  4 Sep 2009 18:41:12 +0200 (MEST)
> 
>> Any comments and test results welcome :)
> 
> This looks really nice.  I have them already checked into my
> local net-next-2.6 tree and will push them out after I do
> some multiqueue testing with NIU.

Thanks. Attached is a small fix on top hat fixes inverted logic
in mq_destroy().

diff --git a/net/sched/sch_mq.c b/net/sched/sch_mq.c
index 5e453fd..c84dec9 100644
--- a/net/sched/sch_mq.c
+++ b/net/sched/sch_mq.c
@@ -26,7 +26,7 @@ static void mq_destroy(struct Qdisc *sch)
 	struct mq_sched *priv = qdisc_priv(sch);
 	unsigned int ntx;
 
-	if (priv->qdiscs)
+	if (!priv->qdiscs)
 		return;
 	for (ntx = 0; ntx < dev->num_tx_queues && priv->qdiscs[ntx]; ntx++)
 		qdisc_destroy(priv->qdiscs[ntx]);