Subject: Re: [PATCH 2/2] ems_usb: Added support for EMS CPC-USB/ARM7 CAN/USB interface

From: Eric Dumazet <[email-masked]>
Date: Tue, 15 Sep 2009 13:10:34 +0200

Sebastian Haas a écrit :
> This patch adds support for one channel CAN/USB interace CPC-USB/ARM7 from
> EMS Dr. Thomas Wuensche (http://www.ems-wuensche.com).
> 
> Signed-off-by: Sebastian Haas <[email-masked]>
> ---
> 

...

> +	netif_rx(skb);
> +
> +	dev->netdev->last_rx = jiffies;

Please dont update last_rx unless your driver *really* needs to.

drivers/net/sky2.c is an example of driver that has to update ->last_rx
for its internal use.

But most drivers dont need it anymore, since core network
already update it if necessary  (check skb_bond_should_drop())

> +	stats->rx_packets++;
> +	stats->rx_bytes += cf->can_dlc;
> +}
> +