From: Danny Feng <dfeng@redhat•com>
To: Shan Wei <shanwei@cn•fujitsu.com>
Cc: davem@davemloft•net, kaber@trash•net, yoshfuji@linux-ipv6•org,
jmorris@namei•org, pekkas@netcore•fi, kuznet@ms2•inr.ac.ru,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
Marc Milgram <mmilgram@redhat•com>
Subject: Re: [PATCH 2/2] ipv4: make do_ip_setsockopt for IP_MULTICAST_IF support ip_mreq struct
Date: Thu, 17 Sep 2009 17:19:16 +0800 [thread overview]
Message-ID: <4AB1FF14.6000801@redhat.com> (raw)
In-Reply-To: <4AB1FE6E.9000201@cn.fujitsu.com>
On 09/17/2009 05:16 PM, Shan Wei wrote:
> Xiaotian Feng wrote, at 09/17/2009 01:20 PM:
>> ip_mreq and ip_mreqn is almost the same, and do_ip_setsockopt for IP_MULTICAST_IF
>> part supported ip_mreqn struct. This patch adds support for ip_mreq struct.
>>
>
> It's not meaning to support the ip_mreq struct, the imr_multiaddr member
> never be used by the IP_MULTICAST_IF.
>
> In addition, using the option normally like this:
> struct in_addr interface_addr;
> setsockopt (socket, IPPROTO_IP, IP_MULTICAST_IF,&interface_addr, sizeof(interface_addr));
>
> Do your patch suggest using the option like this?
> struct ip_mreq mreq;
> setsockopt (socket, IPPROTO_IP, IP_MULTICAST_IF,&mreq, sizeof(mreq));
>
In fact, current implemetation supports:
struct ip_mreqn mreqn;
setsockopt(socket, IPPROTO_IP, IP_MULTICAST_IF, &mreqn, sizeof(mreqn));
Then why not support mreq?
>
> Best Regards
> -----
> Shan Wei
>
next prev parent reply other threads:[~2009-09-17 9:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 5:20 [PATCH 2/2] ipv4: make do_ip_setsockopt for IP_MULTICAST_IF support ip_mreq struct Xiaotian Feng
2009-09-17 9:16 ` Shan Wei
2009-09-17 9:19 ` Danny Feng [this message]
2009-09-17 9:36 ` Alexey Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB1FF14.6000801@redhat.com \
--to=dfeng@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jmorris@namei$(echo .)org \
--cc=kaber@trash$(echo .)net \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mmilgram@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pekkas@netcore$(echo .)fi \
--cc=shanwei@cn$(echo .)fujitsu.com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox