From: Suresh Jayaraman <sjayaraman@suse•de>
To: David Rientjes <rientjes@google•com>
Cc: Linus Torvalds <torvalds@linux-foundation•org>,
Andrew Morton <akpm@linux-foundation•org>,
linux-kernel@vger•kernel.org, linux-mm@kvack•org,
netdev@vger•kernel.org, Neil Brown <neilb@suse•de>,
Miklos Szeredi <mszeredi@suse•cz>, Wouter Verhelst <w@uter•be>,
Peter Zijlstra <a.p.zijlstra@chello•nl>,
trond.myklebust@fys•uio.no
Subject: Re: [PATCH 03/31] mm: expose gfp_to_alloc_flags()
Date: Fri, 02 Oct 2009 13:41:10 +0530 [thread overview]
Message-ID: <4AC5B59E.3050608@suse.de> (raw)
In-Reply-To: <alpine.DEB.1.00.0910011355230.32006@chino.kir.corp.google.com>
David Rientjes wrote:
> On Thu, 1 Oct 2009, Suresh Jayaraman wrote:
>
>> From: Peter Zijlstra <a.p.zijlstra@chello•nl>
>>
>> Expose the gfp to alloc_flags mapping, so we can use it in other parts
>> of the vm.
>>
>> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello•nl>
>> Signed-off-by: Suresh Jayaraman <sjayaraman@suse•de>
>
> Nack, these flags are internal to the page allocator and exporting them to
> generic VM code is unnecessary.
Yes, you're right.
> The only bit you actually use in your patchset is ALLOC_NO_WATERMARKS to
> determine whether a particular allocation can use memory reserves. I'd
> suggest adding a bool function that returns whether the current context is
> given access to reserves including your new __GFP_MEMALLOC flag and
> exporting that instead.
Makes sense and Neil already posted a patch citing the suggested
changes, will incorporate the change.
Thanks,
--
Suresh Jayaraman
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack•org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack•org"> email@kvack•org </a>
prev parent reply other threads:[~2009-10-02 8:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 14:05 [PATCH 03/31] mm: expose gfp_to_alloc_flags() Suresh Jayaraman
2009-10-01 21:03 ` David Rientjes
2009-10-02 5:04 ` Neil Brown
2009-10-02 9:30 ` David Rientjes
2009-10-02 8:11 ` Suresh Jayaraman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC5B59E.3050608@suse.de \
--to=sjayaraman@suse$(echo .)de \
--cc=a.p.zijlstra@chello$(echo .)nl \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=mszeredi@suse$(echo .)cz \
--cc=neilb@suse$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rientjes@google$(echo .)com \
--cc=torvalds@linux-foundation$(echo .)org \
--cc=trond.myklebust@fys$(echo .)uio.no \
--cc=w@uter$(echo .)be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox