Subject: Re: [net-next-2.6 PATCH 6/9] vxge: Check if FCS stripping is disabled by the firmware.

From: Eric Dumazet <[email-masked]>
Date: Mon, 05 Oct 2009 15:04:32 +0200

Sreenivasa Honnur a écrit :
> - Added a function to check if FCS stripping is disabled by the firmware, if
>   it is not disabled fail driver load.
> 
> - By default FCS stripping is disabled by the firmware. With this assumption
>   driver decrements the indicated packet length by 4 bytes(FCS length).
> 
> - This patch ensures that FCS stripping is disabled during driver load time.
> 
> Signed-off-by: Sreenivasa Honnur <[email-masked]>

What the big deal about FCS not being stripped ?

Denying driver load for this litle detail seems very hard.
You could issue a warning if there is a performance hit, but allow the driver
to function.

If this adapter has the ability to disable/enable it at firmware level,
you might replace

pkt_length -= ETH_FCS_LEN;

by :

pkt_length -= adapter->fcs_length;  

Granted you initialized adapter->fcs_length to 0 or 4 depending on firmware setup.