From: Brice Goglin <bgoglin@free•fr>
To: Rick Jones <rick.jones2@hp•com>
Cc: David Miller <davem@davemloft•net>,
brice@myri•com, netdev@vger•kernel.org, gallatin@myri•com
Subject: Re: [PATCH net-next] myri10ge: add adaptive coalescing
Date: Wed, 07 Oct 2009 07:17:46 +0200 [thread overview]
Message-ID: <4ACC247A.9020504@free.fr> (raw)
In-Reply-To: <4ACBEEB2.7010703@hp.com>
Rick Jones wrote:
> David Miller wrote:
>> From: Brice Goglin <brice@myri•com>
>> Date: Tue, 06 Oct 2009 18:52:43 +0200
>>
>>
>>> This patch adds support for adaptive interrupt coalescing to the
>>> myri10ge driver. It is based on the host periodically look at
>>> statistics and update the NIC coalescing accordingly.
>>>
>>> The NIC only provides packet throughput and we feel that it is a
>>> better heuristics than the packet rate heuristics currently used
>>> in ethtool. Also, assuming that the packet packet rate heuristics
>>> uses what is actually sent on the wire when using TSO, it would be
>>> much more expensive to implement correctly, as the driver would
>>> need to calculate how many packets were sent.
>>>
>>> Signed-off-by: Andrew Gallatin <gallatin@myri•com>
>>> Signed-off-by: Brice Goglin <brice@myri•com>
>>
>>
>> Drivers tried to do this as far back as 6 years ago (tg3) and we don't
>> recommend doing this with NAPI drivers.
>
> Doesn't e1000(e) still try to do adaptive coalescing?
mlx_en, benet, sfc, ... do as well.
Brice
next prev parent reply other threads:[~2009-10-07 5:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 16:52 [PATCH net-next] myri10ge: add adaptive coalescing Brice Goglin
2009-10-07 0:25 ` David Miller
2009-10-07 1:28 ` Rick Jones
2009-10-07 5:17 ` Brice Goglin [this message]
2009-10-07 5:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACC247A.9020504@free.fr \
--to=bgoglin@free$(echo .)fr \
--cc=Brice.Goglin@ens-lyon$(echo .)org \
--cc=brice@myri$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gallatin@myri$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rick.jones2@hp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox