Subject: Re: [BUILD-FAILURE] next-20091015 - vbus_enet driver breaks with allmodconfig

From: Gregory Haskins <[email-masked]>
Date: Thu, 15 Oct 2009 20:29:09 -0400

Kamalesh Babulal wrote:
> Hi Gregory,
> 
> 	While building next-20091015 with allmodconfig on the powerpc
> vbus-enet driver breaks
> 
> MODPOST 2492 modules
> ERROR: ".vbus_driver_register" [drivers/net/vbus-enet.ko] undefined!
> ERROR: ".vbus_driver_unregister" [drivers/net/vbus-enet.ko] undefined!
> ERROR: ".vbus_driver_ioq_alloc" [drivers/net/vbus-enet.ko] undefined!
> 
> CONFIG_VBUS_ENET=m
> CONFIG_VBUS_ENET_DEBUG=y
> CONFIG_VBUS_PROXY=n

Hi Kamalesh,

Please try the following patch:

commit 1de440616ac84679902d045b4476effcebfae400
Author: Gregory Haskins <[email-masked]>
Date:   Thu Oct 15 20:25:05 2009 -0400

    net: fix vbus-enet Kconfig dependencies

    We currently select VBUS_PROXY when vbus-enet is enabled, which is
    the wrong direction.  Not all platforms will define VBUS-PROXY, and
    venet depends on its inclusion.  Therefore, lets fix vbus-enet to
    properly depend on the presence of VBUS_PROXY to get this right.

    Signed-off-by: Gregory Haskins <[email-masked]>

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 47dfa04..c9128ea 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -3233,7 +3233,7 @@ config VIRTIO_NET
 config VBUS_ENET
        tristate "VBUS Ethernet Driver"
        default n
-       select VBUS_PROXY
+       depends on VBUS_PROXY
        help
           A virtualized 802.x network device based on the VBUS
           "virtual-ethernet" interface.  It can be used with any