Subject: Re: [PATCH 6/9] ser_gigaset: checkpatch cleanup

From: Tilman Schmidt <[email-masked]>
Date: Mon, 26 Oct 2009 00:36:58 +0100

Alan Cox schrieb:

>> -		if (!(bcs->tx_skb = skb_dequeue(&bcs->squeue)))
>> +		nextskb = skb_dequeue(&bcs->squeue);
>> +		if (!nextskb)
>>  			/* no skb either, nothing to do */
>>  			return;
>> +		bcs->tx_skb = nextskb;
> 
> This does not do the same thing as before
> 
> Previously the NULL case assigned to bcs->tx_skb, now it does not.

bcs->tx_skb is guaranteed to be NULL already at this point because
of the enclosing "if (!bcs->tx_skb)".

Thanks,
Tilman

-- 
Tilman Schmidt                    E-Mail: [email-masked]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)