Subject: Re: [PATCH] net: Support specifying the network namespace upon device creation.

From: Eric Dumazet <[email-masked]>
Date: Tue, 03 Nov 2009 10:28:27 +0100

Eric W. Biederman a écrit :
> There is no good reason to not support userspace specifying the
> network namespace during device creation, and it makes it easier
> to create a network device and pass it to a child network namespace
> with a well known name.
> 
> We have to be careful to ensure that the target network namespace
> for the new device exists through the life of the call.  To keep
> that logic clear I have factored out the network namespace grabbing
> logic into rtnl_link_get_net.
> 
> In addtion we need to continue to pass the source network namespace
> to the rtnl_link_ops.newlink method so that we can find the base
> device source network namespace.
> 
> Signed-off-by: Eric W. Biederman <[email-masked]>

Very nice, with only one long line you could wrap differently.
  
> -static int ipgre_newlink(struct net_device *dev, struct nlattr *tb[],
> +static int ipgre_newlink(struct net *src_net, struct net_device *dev, struct nlattr *tb[],
>  			 struct nlattr *data[])
>  {
>  	struct ip_tunnel *nt;