Subject: Re: [PATCH net-next2.6] ipv6: avoid dev_hold()/dev_put() in rawv6_bind()

From: Brian Haley <[email-masked]>
Date: Fri, 06 Nov 2009 11:48:46 -0500

Eric Dumazet wrote: 
> @@ -257,6 +257,7 @@ static int rawv6_bind(struct sock *sk, struct sockaddr *uaddr, int addr_len)
>  	if (sk->sk_state != TCP_CLOSE)
>  		goto out;
>  
> +	rcu_read_unlock();
>  	/* Check if the address belongs to the host. */
>  	if (addr_type != IPV6_ADDR_ANY) {
>  		struct net_device *dev = NULL;

This was supposed to be rcu_read_lock(), right?

-Brian