Subject: Re: [PATCH] netdev: fold name hash properly (v3)

From: Eric Dumazet <[email-masked]>
Date: Tue, 10 Nov 2009 18:37:11 +0100

Stephen Hemminger a écrit :
> The full_name_hash function does not produce well distributed values in
> the lower bits, so most code uses hash_32() to fold it.  This is really
> a bug introduced when name hashing was added, back in 2.5 when I added
> name hashing.
> 
> hash_32 is all that is needed since full_name_hash returns unsigned int
> which is only 32 bits on 64 bit platforms.
> 
> Also, there is no point in using hash_32 on ifindex, because the is naturally
> sequential and usually well distributed.
> 
> Signed-off-by: Stephen Hemminger <[email-masked]>
> 

Signed-off-by: Eric Dumazet <[email-masked]>

Thanks Stephen