Subject: Re: [PATCH 1/4] drivers/net/enic: decrement sizeof size in strncmp

From: Jörg-Volker Peetz <[email-masked]>
Date: Thu, 12 Nov 2009 11:17:24 +0100

Julia Lawall wrote:
> From: Julia Law all <[email-masked]>
> 
> As observed by Joe Perches, sizeof of a constant string includes the
> trailing 0.  If what is wanted is to check the initial characters of
> another string, this trailing 0 should not be taken into account.  If an
> exact match is wanted, strcmp should be used instead.
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression foo;
> constant char *abc;
> @@
> 
> strncmp(foo, abc, 
> - sizeof(abc)
> + sizeof(abc)-1
>  )
> // </smpl>
> 
<snip>
How about this pattern (uses length of first argument):

strncmp(foo, abc,
- sizeof(foo)

?
-- 
Best regards,
Jörg-Volker.