From: "Séguier Régis" <rseguier@e-teleport•net>
To: Kevin Shanahan <kmshanah@disenchant•net>
Cc: netdev@vger•kernel.org
Subject: Re: Problem with VLANs and via-velocity driver
Date: Fri, 13 Nov 2009 11:36:49 +0100 [thread overview]
Message-ID: <4AFD36C0.3090302@e-teleport.net> (raw)
In-Reply-To: <4AFCFF67.3060802@trash.net>
Patrick McHardy a écrit :
> Kevin Shanahan wrote:
>
>> Hi,
>>
>> I've had some problems with getting a fairly simple (I thought) VLAN
>> configuration working with the on board Via NICs on my Via M700
>> board. Looks like as soon as a tagged VLAN interface is added, the
>> underlying "raw" (untagged) interface stops responding.
>>
>> ...
>>
>> A bit of searching found a few references to similar problems going
>> back a few years (2005, 2007). Sounded like there were some driver
>> issues, but it wasn't clear from the messages I found whether they
>> were believed to be fixed or not. I tried the same test using a
>> differnt NIC with the tg3 driver and there were no problems, so it
>> looks to me like it's still a via-velocity issue. Unfortunately I
>> don't have room to add NICs to this machine and need to use the on
>> board Via hardware.
>>
>
> There's some special-casing for VID 0 in velocity_init_cam_filter().
> Does "ip link add link eth0 type vlan id 0" make any difference?
> If not, does "ip link set eth0 promisc on"?
>
When we patch the driver to support multiple vlan, we decide to use the
vlan 0 to desactivate the vlan filtering.
via-velocity: fix vlan receipt
- vlans were using a single CAM register (see mac_set_vlan_cam)
- setting the address filtering registers for vlans is not
needed when there is no vlan
The non-tagged interface is filtered out as soon as a tagged
(!= 0) interface is created. Its traffic appears again when an
zero-tagged interface is created.
Tested on Via Epia SN (VT6130 chipset) with several vlans whose
tag was above or beyond 255.
Signed-off-by: Séguier Régis <rseguier@e-teleport•net>
Acked-by: Francois Romieu <romieu@fr•zoreil.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat•com>
--
Régis Séguier
next prev parent reply other threads:[~2009-11-13 11:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-13 3:32 Problem with VLANs and via-velocity driver Kevin Shanahan
2009-11-13 6:40 ` Patrick McHardy
2009-11-13 10:36 ` Séguier Régis [this message]
2009-11-13 11:11 ` Patrick McHardy
2009-11-13 11:40 ` Séguier Régis
2009-11-19 15:17 ` Patrick McHardy
2009-11-16 0:57 ` Kevin Shanahan
2009-11-19 15:18 ` Patrick McHardy
2010-02-10 16:43 ` Tiago Pierezan Camargo
2010-02-10 16:46 ` Patrick McHardy
2010-02-11 16:50 ` Tiago Pierezan Camargo
2010-02-11 16:59 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFD36C0.3090302@e-teleport.net \
--to=rseguier@e-teleport$(echo .)net \
--cc=kmshanah@disenchant$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=technique@e-teleport$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox