From: Patrick McHardy <kaber@trash•net>
To: Andy Gospodarek <andy@greyhouse•net>
Cc: netdev@vger•kernel.org, fubar@us•ibm.com
Subject: Re: [PATCH net-next-2.6] bonding: allow arp_ip_targets to be on a separate vlan from bond device
Date: Tue, 01 Dec 2009 10:42:44 +0100 [thread overview]
Message-ID: <4B14E514.8070400@trash.net> (raw)
In-Reply-To: <20091130205333.GG1639@gospo.rdu.redhat.com>
Andy Gospodarek wrote:
> On Mon, Nov 30, 2009 at 09:22:33PM +0100, Patrick McHardy wrote:
>> Andy Gospodarek wrote:
>>> diff --git a/net/8021q/vlan_core.c b/net/8021q/vlan_core.c
>>> index e75a2f3..8d8a778 100644
>>> --- a/net/8021q/vlan_core.c
>>> +++ b/net/8021q/vlan_core.c
>>> @@ -14,6 +14,7 @@ int __vlan_hwaccel_rx(struct sk_buff *skb, struct vlan_group *grp,
>>> if (skb_bond_should_drop(skb))
>>> goto drop;
>>>
>>> + skb->skb_iif = skb->dev->ifindex;
>>> __vlan_hwaccel_put_tag(skb, vlan_tci);
>>> skb->dev = vlan_group_get_device(grp, vlan_tci & VLAN_VID_MASK);
>>>
>>> @@ -85,6 +86,7 @@ vlan_gro_common(struct napi_struct *napi, struct vlan_group *grp,
>>> if (skb_bond_should_drop(skb))
>>> goto drop;
>>>
>>> + skb->skb_iif = skb->dev->ifindex;
>>> __vlan_hwaccel_put_tag(skb, vlan_tci);
>>> skb->dev = vlan_group_get_device(grp, vlan_tci & VLAN_VID_MASK);
>>>
>> How about pulling the skb->iif assignment in netif_receive_skb() up
>> before the vlan_hwaccel_do_receive() call instead?
>
> I'm not sure how that will help. My goal with the two changes in
> vlan_core.c was to capture the input device index before we lost it --
> which is precisely what happens when coming up through a driver like
> bnx2 that supports vlan acceleration:
>
> (NAPI poll)
> bnx2_poll
> bnx2_poll_work
> bnx2_rx_int
> vlan_hwaccel_receive_skb
> __vlan_hwaccel_rx
> (skb->dev set to vlan device)
> netif_receive_skb
>
> In that case, setting skb_iif in netif_receive_skb would be too late.
> The original dev would no longer be known.
Right, I've misread your patch, sorry.
next prev parent reply other threads:[~2009-12-01 9:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 20:14 [PATCH net-next-2.6] bonding: allow arp_ip_targets to be on a separate vlan from bond device Andy Gospodarek
2009-11-30 20:22 ` Patrick McHardy
2009-11-30 20:53 ` Andy Gospodarek
2009-12-01 9:42 ` Patrick McHardy [this message]
2009-12-01 0:00 ` Jay Vosburgh
2009-12-01 1:21 ` Andy Gospodarek
2009-12-01 1:57 ` Jay Vosburgh
2009-12-01 14:44 ` Andy Gospodarek
2009-12-01 21:28 ` Jay Vosburgh
2009-12-01 23:07 ` Andy Gospodarek
2009-12-02 21:24 ` Andy Gospodarek
2009-12-07 18:13 ` Andy Gospodarek
2009-12-07 18:24 ` Eric Dumazet
2009-12-09 22:01 ` [PATCH net-next-2.6 v3] bonding: allow arp_ip_targets on separate vlans to use arp validation Andy Gospodarek
2009-12-11 5:17 ` Jay Vosburgh
2009-12-14 20:48 ` [PATCH net-next-2.6 v4] " Andy Gospodarek
2009-12-26 2:22 ` David Miller
2009-12-28 15:26 ` Andy Gospodarek
2009-12-28 15:33 ` David Miller
2009-12-28 21:55 ` Jay Vosburgh
2009-12-29 0:51 ` Andy Gospodarek
2010-01-04 5:19 ` David Miller
2009-12-01 4:11 ` [PATCH net-next-2.6] bonding: allow arp_ip_targets to be on a separate vlan from bond device Eric Dumazet
2009-12-02 5:13 ` Eric Dumazet
2009-12-02 16:38 ` Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B14E514.8070400@trash.net \
--to=kaber@trash$(echo .)net \
--cc=andy@greyhouse$(echo .)net \
--cc=fubar@us$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox