Subject: Re: ipv4 05/05: add sysctl to accept packets with local source addresses

From: Patrick McHardy <[email-masked]>
Date: Fri, 04 Dec 2009 08:55:51 +0100

Eric W. Biederman wrote:
> Patrick McHardy <[email-masked]> writes:
> 
>> commit 8ec1e0ebe26087bfc5c0394ada5feb5758014fc8
>> Author: Patrick McHardy <[email-masked]>
>> Date:   Thu Dec 3 12:16:35 2009 +0100
>>
>>     ipv4: add sysctl to accept packets with local source addresses
>>     
>>     Change fib_validate_source() to accept packets with a local source address when
>>     the "accept_local" sysctl is set for the incoming inet device. Combined with the
>>     previous patches, this allows to communicate between multiple local interfaces
>>     over the wire.
>>     
>>     Signed-off-by: Patrick McHardy <[email-masked]>
>>
> 
> Obligatory grumble. New binary sysctl.  Grumble.
> 
> Honestly this might be the one new sysctl that doesn't conflict with
> my sysctl tree.  That should merge to Linus sometime this merge cycle
> which will stop exporting this to userspace. So I don't have any
> real complaints.  Grumble.
> 
> This overloading of sysctl.h for the binary sysctl numbers and
> the index into the perdevice sysctls is something we should probably
> change at some point to keep maintenance a little less confusing.

Yes, unfortunately its currently not possible to add inetdev sysctls
without allocating new numbers.