Subject: Re: [PATCH] netfilter: Fix compiler warning.

From: Patrick McHardy <[email-masked]>
Date: Thu, 10 Dec 2009 12:26:38 +0100

Eric Dumazet wrote:
> Le 10/12/2009 02:25, [email-masked] a écrit :
>> Fix compiler warning "discards qualifiers from pointer target type".
>> The function prototype defines parameters as pointer to a constant.
>> Such parameters should not have their content modified in the
>> function.
>>
>> Signed-off-by: Laurent Chavey <[email-masked]>
> 
> This is not the right fix IMHO.
> 
> We want an unique timestamp for the whole netfilter matches, because several 'time' rules
> could get 'interesting' effects.
> 
> The 'const' attribute is a debugging aid, and the skb->tstamp 'write-once' is a valid exception.

I agree, the timestamps should be consistent among multiple
matches. The cast should also surpress the warning, but some
gcc versions ignore it.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to [email-masked]
More majordomo info at  http://vger.kernel.org/majordomo-info.html