Subject: Re: [PATCH] net-ipv4-tcp.c-fix-warning-from-older-compilers.patch

From: Eric Dumazet <[email-masked]>
Date: Thu, 10 Dec 2009 16:31:30 +0100

Le 10/12/2009 15:16, William Allen Simpson a écrit :
> Replace + net-ipv4-tcpc-fix-warning.patch added to -mm tree
> 
> Remove the offending code, and replace with comments.  This is an
> unlikely problem, so depend on human finding any future error.
> 
> Signed-off-by: [email-masked]
> ---
>  net/ipv4/tcp.c |    9 ++++-----
>  1 files changed, 4 insertions(+), 5 deletions(-)

This is not necessary, David already _did_ the thing, and _told_ so.

You probably missed fact we are in merge window, so fixes (and only fixes)
are pushed into net-2.6 tree.

When Linus closes this merge window (issuing a linux-2.6.33-rc1 tag),
then David re-opens net-next-2.6 tree for new stuff.

http://git2.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=commitdiff;h=3dc789320e1b310cb505dcd94512c279abcd5e1c

commit 3dc789320e1b310cb505dcd94512c279abcd5e1c
Author: David S. Miller <[email-masked]>
Date:   Tue Dec 8 20:07:54 2009 -0800

    tcp: Remove runtime check that can never be true.

    GCC even warns about it, as reported by Andrew Morton:

    net/ipv4/tcp.c: In function 'do_tcp_getsockopt':
    net/ipv4/tcp.c:2544: warning: comparison is always false due to limited range of data type

    Signed-off-by: David S. Miller <[email-masked]>