Subject: Re: [PATCH 4/7] can/at91: don't check platform_get_irq's return value against zero

From: Wolfgang Grandegger <[email-masked]>
Date: Wed, 16 Dec 2009 17:27:03 +0100

Uwe Kleine-König wrote:
> platform_get_irq returns -ENXIO on failure, so !irq was probably
> always true.  Better use (int)irq <= 0.  Note that a return value of
> zero is still handled as error even though this could mean irq0.

But only on ARM, which is the only platform still using the infamous
NO_IRQ (=-1). As this is a driver for ARM hardware, using irq == NO_IRQ
would make sense, though.

Wolfgang.