Subject: Re: [PATCH] netem/iproute2 solving correlated loss issues [0/5]

From: Stefano Salsano <[email-masked]>
Date: Sat, 19 Dec 2009 10:45:32 +0100

David Miller wrote:
>> The patch is backward compatible, we have not removed the previous...
> 
> To heck it is!
> The changed version of iproute2 will not work without the kernel
> changes installed.  The kernel validates the size of the structures
> passed in, you can't change the user visible interface like this.

David Miller wrote:
 > Furthermore it is fundamentally flawed in it's implementation
 > in that the user exported data structures cannot be changed,
 > you cannot change the layout and you absolutely cannot
 > change the size of these things or else various tool and
 > kernel combinations stop working.

thank you for raising these fundamental issues !
we will address them and resubmit the patch when done...

 > Add new netlink attributes to extend things, that's the "real"
 > backwards compatible way to make changes to netlink interfaces.

point taken

-- 
*******************************************************************
Stefano Salsano
Dipartimento Ingegneria Elettronica
Universita' di Roma "Tor Vergata"
Via del Politecnico, 1 - 00133 Roma - ITALY

http://netgroup.uniroma2.it/Stefano_Salsano/

E-mail  : [email-masked]
Cell.   : +39 320 4307310
Office  : (Tel.) +39 06 72597770  (Fax.) +39 06 72597435
*******************************************************************