Subject: [TCP]: min_t/max_t confusion in tcp_select_initial_window()?

From: Roel Kluin <[email-masked]>
Date: Wed, 23 Dec 2009 03:00:24 +0100

I could be confused, but in net/ipv4/tcp_output.c:217:

                space = max_t(u32, sysctl_tcp_rmem[2], sysctl_rmem_max);
                space = min_t(u32, space, *window_clamp);
------------------------^^^^^

shouldn't the min_t and max_t be exchanged? i.e.

                space = min_t(u32, sysctl_tcp_rmem[2], sysctl_rmem_max);
                space = max_t(u32, space, *window_clamp);

Thanks, Roel