Subject: Re: [RESEND PATCH 1/4] stmmac: thinking about a generic driver for Synopsys Controllers.

From: Giuseppe CAVALLARO <[email-masked]>
Date: Mon, 04 Jan 2010 08:21:01 +0100

Hi David,

David Miller wrote:
> From: Giuseppe CAVALLARO <[email-masked]>
> Date: Wed, 16 Dec 2009 08:26:42 +0100
> 
>> The idea behind this patch is to start thinking about a
>> generic driver for Synopsys Ethernet Controllers
>> starting from the stmmac device driver.
> 
> This patch does too much at once.
> 
> It changes Kconfig help test.
> 
> It moves many things around to many new files.
> 
> It's therefore too large to review as a unit.
> 
> Please split this up into several (many) pieces.
> One for each specific action.
> 
> One patch might improve the help test.  Another might
> move DMA operations out to a seperate file, another might
> move another class of operations into a new file.
> 
> And at each step of the way the driver must compile and work
> properly.

I'll do that and resend all the patches to be reviewed.

Thanks,
Peppe

> 
> Thanks.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [email-masked]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>