From: "Németh Márton" <nm127@freemail•hu>
To: Jeff Garzik <jgarzik@pobox•com>,
Network Development <netdev@vger•kernel.org>
Cc: Julia Lawall <julia@diku•dk>, cocci@diku•dk
Subject: [PATCH] 8139too: make PCI device ids constant
Date: Tue, 05 Jan 2010 00:03:02 +0100 [thread overview]
Message-ID: <4B4273A6.4020102@freemail.hu> (raw)
From: Márton Németh <nm127@freemail•hu>
The id_table field of the struct pci_driver is constant in <linux/pci.h>
so it is worth to make pci_device_id also constant.
The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
identifier I1, I2, x;
@@
struct I1 {
...
const struct I2 *x;
...
};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
struct I1 y = {
.x = E,
};
@c@
identifier r.I2;
identifier s.E;
@@
const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+ const
struct I2 E[] = ...;
// </smpl>
Signed-off-by: Márton Németh <nm127@freemail•hu>
Cc: Julia Lawall <julia@diku•dk>
Cc: cocci@diku•dk
---
diff -u -p a/drivers/net/pci-skeleton.c b/drivers/net/pci-skeleton.c
--- a/drivers/net/pci-skeleton.c 2009-12-27 12:20:35.000000000 +0100
+++ b/drivers/net/pci-skeleton.c 2010-01-03 21:08:03.000000000 +0100
@@ -211,7 +211,7 @@ static struct {
};
-static struct pci_device_id netdrv_pci_tbl[] = {
+static const struct pci_device_id netdrv_pci_tbl[] = {
{0x10ec, 0x8139, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
{0x10ec, 0x8138, PCI_ANY_ID, PCI_ANY_ID, 0, 0, NETDRV_CB },
{0x1113, 0x1211, PCI_ANY_ID, PCI_ANY_ID, 0, 0, SMC1211TX },
diff -u -p a/drivers/net/8139too.c b/drivers/net/8139too.c
--- a/drivers/net/8139too.c 2009-12-27 12:20:30.000000000 +0100
+++ b/drivers/net/8139too.c 2010-01-03 21:25:05.000000000 +0100
@@ -231,7 +231,7 @@ static const struct {
};
-static struct pci_device_id rtl8139_pci_tbl[] = {
+static const struct pci_device_id rtl8139_pci_tbl[] = {
{0x10ec, 0x8139, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
{0x10ec, 0x8138, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
{0x1113, 0x1211, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
next reply other threads:[~2010-01-04 23:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-04 23:03 Németh Márton [this message]
2010-01-07 8:33 ` [PATCH] 8139too: make PCI device ids constant David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4273A6.4020102@freemail.hu \
--to=nm127@freemail$(echo .)hu \
--cc=cocci@diku$(echo .)dk \
--cc=jgarzik@pobox$(echo .)com \
--cc=julia@diku$(echo .)dk \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox