From: Eric Dumazet <eric.dumazet@gmail•com>
To: David Stevens <dlstevens@us•ibm.com>
Cc: Flavio Leitner <fbl@sysclose•org>,
David Miller <davem@davemloft•net>,
netdev@vger•kernel.org, netdev-owner@vger•kernel.org
Subject: Re: [PATCH] igmp: fix ip_mc_sf_allow race
Date: Tue, 05 Jan 2010 07:55:14 +0100 [thread overview]
Message-ID: <4B42E252.1080405@gmail.com> (raw)
In-Reply-To: <OF7FCD6D97.5F7C3DD3-ON882576A2.00001FF7-882576A2.00009335@us.ibm.com>
Le 05/01/2010 01:06, David Stevens a écrit :
> For readability, instead of:
>
> ret = X;
> if (condition)
> goto out;
>
> I prefer:
>
> if (condition) {
> ret = X;
> goto out;
> }
>
> which makes it clear that ret is for the return and not
> some random state change unrelated to the condition.
>
Linus argument for this common Linux coding style is that generated code is smaller
mov $-6,%eax
cmp condition
je out
versus
cmp condition
jne .ok
mov $-6,%eax
jmp out
.ok:
next prev parent reply other threads:[~2010-01-05 6:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-30 14:23 [PATCH] igmp: fix ip_mc_sf_allow race Flavio Leitner
2010-01-04 5:54 ` David Miller
2010-01-04 11:29 ` Flavio Leitner
2010-01-04 13:07 ` Eric Dumazet
2010-01-04 18:51 ` Flavio Leitner
2010-01-04 19:53 ` Eric Dumazet
2010-01-05 0:06 ` David Stevens
2010-01-05 6:55 ` Eric Dumazet [this message]
2010-01-05 20:52 ` [PATCH] igmp: fix ip_mc_sf_allow race [v3] Flavio Leitner
2010-01-05 22:36 ` Eric Dumazet
2010-01-05 23:03 ` Stephen Hemminger
2010-01-06 16:40 ` Paul E. McKenney
2010-01-06 17:10 ` Stephen Hemminger
2010-01-06 18:50 ` Paul E. McKenney
2010-01-28 16:13 ` [PATCH] igmp: fix ip_mc_sf_allow race [v5] Flavio Leitner
2010-02-02 15:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B42E252.1080405@gmail.com \
--to=eric.dumazet@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dlstevens@us$(echo .)ibm.com \
--cc=fbl@sysclose$(echo .)org \
--cc=netdev-owner@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox